[Solved] "only one flySpectator allowed"

[x3n]

When I start michi's moonstation level a second time, Orxonox crashes.

errorlog:

Assertion failed: ghost == NULL && "only one flySpectator allowed", file world_entities/spectator.cc, line 138

Looks like the spectator doesn't get destroyed when the level ends.
Maybe someone could have a look at that.

[patrick]

Spectator is a world entity and therefore _should_ be destroyed like every other WE. in theory

Where do they get the spectator reference from? Perhaps that pointer is not reset properly.

[chrigi]

In which branch does this happen?

[x3n]

Main branch; trunk

[x3n]

Adding the marked line to the destructor in spectator.cc solves the problem, but I don't know if this is a good solution.

Code: Select all

Spectator::~Spectator ()
{
  this->setPlayer(NULL);
  ghost = NULL;  <-----------------------
}

[chrigi]

Adding the marked line to the destructor in spectator.cc solves the problem, but I don't know if this is a good solution.

Code: Select all

Spectator::~Spectator ()
{
  this->setPlayer(NULL);
  ghost = NULL;  <-----------------------
}

I suggest this solution. so deleting of an other spectator won't set ghost = NULL

Code: Select all

Spectator::~Spectator ()
{
  this->setPlayer(NULL);
  if ( this == ghost )
    ghost = NULL;
}

Does this solve the problem?

Could someone commit this? I can't!

Code: Select all

Sending        src/world_entities/spectator.cc
svn: Commit failed (details follow):
svn: CHECKOUT of '/orxonox/!svn/ver/10618/trunk/src/world_entities/spectator.cc': 403 Forbidden (https://svn.orxonox.net)

[silvan]

Code: Select all

Spectator::~Spectator ()
{
  this->setPlayer(NULL);
  if ( this == ghost )
    ghost = NULL;
}

Does this solve the problem?

Could someone commit this? I can't!

Code: Select all

Sending        src/world_entities/spectator.cc
svn: Commit failed (details follow):
svn: CHECKOUT of '/orxonox/!svn/ver/10618/trunk/src/world_entities/spectator.cc': 403 Forbidden (https://svn.orxonox.net)

Done. It's in the trunk.

[x3n]

Thx chrigi, good idea with "this == ghost".
And yes, it seems to work perfectly


@silvan: Thx for commiting

[chrigi]

@x3n: Thx for reporting